Fix intdiv() argument names and description#1551
Merged
php-pulls merged 1 commit intophp:PHP-7.0from Oct 8, 2015
Merged
Conversation
hikari-no-yume
force-pushed
the
intdiv_argument_name_fix
branch
from
3b2c68a to
622bddd
Compare
Contributor
Author
|
I would of course update the manual if this was merged. |
salathe
added a commit
to salathe/phpdoc-en
that referenced
this pull request
Oct 7, 2015
See also php-src PR 1551 [1] for changing this in the source. [1] php/php-src#1551 git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@337965 c90b9560-bf6c-de11-be94-00142212c4b1
svn2github
pushed a commit
to svn2github/phpdoc_en
that referenced
this pull request
Oct 7, 2015
See also php-src PR 1551 [1] for changing this in the source. [1] php/php-src#1551 git-svn-id: http://svn.php.net/repository/phpdoc/en@337965 c90b9560-bf6c-de11-be94-00142212c4b1
LawnGnome
pushed a commit
to LawnGnome/phpdoc-en
that referenced
this pull request
Oct 7, 2015
See also php-src PR 1551 [1] for changing this in the source. [1] php/php-src#1551 git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@337965 c90b9560-bf6c-de11-be94-00142212c4b1
hikari-no-yume
force-pushed
the
intdiv_argument_name_fix
branch
from
622bddd to
fa23beb
Compare
svn2github
pushed a commit
to svn2github/phpdoc_en
that referenced
this pull request
Oct 8, 2015
git-svn-id: http://svn.php.net/repository/phpdoc/en@337970 c90b9560-bf6c-de11-be94-00142212c4b1
salathe
pushed a commit
to salathe/phpdoc-en
that referenced
this pull request
Oct 8, 2015
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@337970 c90b9560-bf6c-de11-be94-00142212c4b1
LawnGnome
pushed a commit
to LawnGnome/phpdoc-en
that referenced
this pull request
Oct 8, 2015
git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@337970 c90b9560-bf6c-de11-be94-00142212c4b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I added
intdiv(), I made the parameter names inconsistent. In mathematics, it's 'numerator and denominator' or 'dividend and divisor', not the weird hybrid I used, 'numerator and divisor'. This pull request corrects the parameter names to be 'dividend and divisor'. It also rewrites the description to be clearer, since 'integer division' is poorly defined.I hope this can get in for 7.0 since it's a tiny documentation fix.