Skip to content

Conversation

DanielEScherzer
Copy link
Member

While php_escape_shell_cmd() did indeed emalloc a string that needed to be freed by the caller in the original implementation that was put in GitHub (see commit 257de2b) a few months ago the return type was changed to use zend_string, see #14353.

While `php_escape_shell_cmd()` did indeed `emalloc` a string that needed to be
freed by the caller in the original implementation that was put in GitHub
(see commit 257de2b) a few months ago the
return type was changed to use `zend_string`, see php#14353.
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@iluuu1994 iluuu1994 closed this in 6c9db60 Oct 12, 2024
@iluuu1994
Copy link
Member

Thanks @DanielEScherzer!

@DanielEScherzer DanielEScherzer deleted the ext-standard-exec branch October 13, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants