Move ARG_(WITH|ENABLE) to the toplevel #16391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`buildconf` (and `phpize`) have special treatment for these "macros". When configure.js is built, all config.w32 are grepped, these "macros" are appended to configure.js, and all config.w32 contents are appended with the "macros" commented out. That means that for `configure` they are in the toplevel anyway, so having them inside of `if` statements in config.w32 is confusing. Note that this matches autoconf behavior.
dstogov
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildconf(andphpize) have special treatment for these "macros". When configure.js is built, all config.w32 are grepped, these "macros" are appended to configure.js, and all config.w32 contents are appended with the "macros" commented out. That means that forconfigurethey are in the toplevel anyway, so having them inside ofifstatements in config.w32 is confusing.Note that this matches autoconf behavior.