Move ARG_ENABLE() "macros" out of confutils.js #16398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While these "macros" work perfectly fine in confutils, it is somewhat strange to have these two there, while all others are in config.w32 files. In particular, there is no need for a `MODE_PHPIZE` guard, since there are already config.w32 and config.w32.phpize.in. However, we need to replace the semicolon the helptext, because the regex which parses ARG_(ENABLE|WITH) calls is restricted, and does not accept semicolons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these "macros" work perfectly fine in confutils, it is somewhat strange to have these two there, while all others are in config.w32 files.
In particular, there is no need for a
MODE_PHPIZEguard, since there are already config.w32 and config.w32.phpize.in.However, we need to replace the semicolon the helptext, because the regex which parses ARG_(ENABLE|WITH) calls is restricted, and does not accept semicolons.
Note that I considered fixing the mentioned regex:
php-src/win32/build/buildconf.js
Line 232 in 18ab3b9
which doesn't do what it is supposed to do (the backslashes are consumed by the JScript string parser, so the parens are just grouping; a final semicolon is optional in JScript), but then saw https://github.com/php/pecl-console-termbox/blob/02a7c1c0a05614bd42e9d624aeda3be90d476f3a/config.w32, which works perfectly fine, although
ARG_ENABLE()andARG_WITH()are commented out. It would not work, though, if the comments were C-style comments.