Fix ICU version specific skip reasons of intl tests #16661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some tests have this backwards, probably reading "skip for ICU …". However, that is not how skip reasons are handled. * Some test seems to have typos in the skip reason version. * Some tests checked for a certain version, but reported the *presumably* next version, which is confusing at best. * Some tests checked versions in descending order, what is not wrong, but confusing. * Some tests had off by one errors. For all tests, we assume that the skipif conditions are correct, and fix the reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all tests, we assume that the skipif conditions are correct, and fix the reasons.
Note that I made this in preparation for #16659, to not completely loose my sanity.