Fix: Remove unused code and improve regex patterns in mail_util.inc #17791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused variable from getHeaders function. - Simplified regex by removing unnecessary lazy quantifiers (). - Removed unnecessary flag from regex patterns. This improves readability and reduces redundant code without altering functionality.
|
Thank you @nzsys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes unused code and simplifies regex patterns in
mail_util.inc, which is part of the standard tests for theext/standardextension. These changes enhance code readability, maintainability, and remove redundant operations without affecting functionality.Details of the changes
$itemsvariable from thegetHeadersfunction.?) in regex patterns.sflag in regex patterns, as it serves no purpose here.