JSON parser method #1904
Merged
JSON parser method #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is just a slight modification (renaming and some small changes) of the patch that has been provided by Andrey Hristov. It adds support for hooking of the json parser operations and allows re-using of modified JSON parsing outside of json ext.
|
What's the intended use case here? |
|
Re-using parser in other extensions. Specifically Andrey is working on a feature for mysqlnd that will use it with its own logic. There might be more use cases for other extensions that need custom json parsing. In addition it could be a good base for json schema validatio / object serialization where would be posible to use different parser methods for that without having perf impact on the default parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces overloading of JSON parsing using callback methods. The initial version was provided by Andrey Hristov and I have done some improvements and API changes into it. The result is an exporting of JSON parser to other extension and no impact on the performance of the current parser. At least my tests didn't show up any visible slowdown with this embed version:
Summary: https://github.com/bukka/php-jsond-bench/blob/master/reports/0002/summary.md
Actual results: https://github.com/bukka/php-jsond-bench/blob/master/reports/0002/runs.md
I think it's ready to go to master. Just creating this PR to check Travis and let others look at it and possibly comment on it.