Fix GH-19932: Zip::setEncryptionName()/setEncryptionIndex() memory leak. #19936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… leak. On successive usage, the password is copied as much but the older address is never freed. Thus, we are hinting a password reset to address it.
nielsdos
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
I wonder if this should be fixed in libzip also (i.e. whether libzip should free the old password).
Anyway, judging by https://github.com/nih-at/libzip/blob/3cd08fb38bbcbda24e9f74834c2b70b906d9069f/lib/zip_file_set_encryption.c#L41 this LGTM
Yes, this should be fixed in libzip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On successive usage, the password is copied as much but the older address is never freed. Thus, we are hinting a password reset to address it.