Skip to content

Remove outdated comment #20125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

Remove outdated comment #20125

merged 1 commit into from
Oct 11, 2025

Conversation

@nielsdos
Copy link
Member

Yes this is correct, the blob is returned as a string so it needs to be put that way into the return value.

@nielsdos
[ci skip] Remove outdated comment
b349e95 
Yes this is correct, the blob is returned as a string so it needs to be
put that way into the return value.
Girgias
Girgias approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this when introducing ZEND_FALLTHROUGH and there wasn't any comment describing if this was intentional or not.

@nielsdos nielsdos merged commit b272021 into php:master Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees

No one assigned

Labels

Extension: pdo_sqlite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nielsdos @Girgias