Skip to content

soap: Fix comment #20126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

soap: Fix comment #20126

merged 1 commit into from
Oct 11, 2025

Conversation

nielsdos
Copy link
Member

The fallthrough isn't right, but it didn't matter as the loop will definitely execute the return statement.

@nielsdos
soap: Fix comment
78eab28 
The fallthrough isn't right, but it didn't matter as the loop will
definitely execute the return statement.
Girgias
Girgias approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking! I added this comment when introducing ZEND_FALLTHROUGH and there wasn't any comment describing if this was intentional or not.

@nielsdos nielsdos merged commit e82ed96 into php:master Oct 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: soap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nielsdos @Girgias