pg_fetch_object() with abstract classes #20180
Conversation
Girgias
force-pushed
the
pgsql-abstract-class
branch
2 times, most recently
from
4755ad0 to
7726761
Compare
…ntiable class name
Girgias
force-pushed
the
pgsql-abstract-class
branch
from
4db2580 to
dc642e8
Compare
|
@devnexen do you know why Windows fails, it says there is an issue with the CLEAN section of the test |
|
I have no real idea honestly. |
| } catch(Throwable $e) { | ||
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: would it be possible to add the closing tag ?
There was a problem hiding this comment.
Might also be the reason windows is confused
| $result = pg_query($db, $sql); | ||
| var_dump(pg_fetch_object($result, NULL, 'E')); | ||
| } catch(Throwable $e) { | ||
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; |
There was a problem hiding this comment.
Maybe try without this last PHP_EOL wdyt ?
|
|
||
| ZVAL_COPY_VALUE(&dataset, return_value); | ||
| object_init_ex(return_value, ce); | ||
| if (UNEXPECTED(EG(exception))) { |
There was a problem hiding this comment.
Check the return value of object_init_ex instead
| object_init_ex(return_value, ce); | ||
| if (UNEXPECTED(EG(exception))) { | ||
| zval_ptr_dtor(&dataset); | ||
| zval_ptr_dtor(return_value); |
There was a problem hiding this comment.
Drop this line , zval_ptr_dtor of the return value followed by a return statement is always wrong.
There was a problem hiding this comment.
In fact, zval_ptr_dtor(&dataset); should also be dropped as dataset is a borrow of the return value.
3 participants
No description provided.