phar: Get rid of bailouts in Phar::webPhar() #20190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bailouts are bad because they stop the GC etc. They also hide leaks. This makes the behaviour equivalent to exit(), as it's meant to stop the request (which is why bailout was used). We also have to fix some leaks that pop up then.
nielsdos
force-pushed
the
phar-webphar-bailouts
branch
from
c97eb45 to
f35c96e
Compare
Girgias
approved these changes
Oct 16, 2025
| switch (Z_TYPE(retval)) { | ||
| case IS_STRING: | ||
| efree(entry); | ||
| /* TODO: avoid relocation??? */ |
There was a problem hiding this comment.
I've got some refactoring that will avoid this. We are kinda stepping on each other's toes, but I'm happy to rework my local changes on top of this.
There was a problem hiding this comment.
Ah right, I had to add the dtor here below for the leak fix and that's how I noticed this.
I'll merge this and let you rebase then.
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Oct 16, 2025
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Oct 16, 2025
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Oct 16, 2025
nielsdos
added a commit
that referenced
this pull request
Oct 17, 2025
* phar: Get rid of last bailouts in phar_file_action() Follow-up on GH-20190. * [ci skip] Drop wrong comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bailouts are bad because they stop the GC etc. They also hide leaks. This makes the behaviour equivalent to exit(), as it's meant to stop the request (which is why bailout was used).
We also have to fix some leaks that pop up then.
This partially depends on @Girgias refactor, so draft until then and will rebase after that is merged.