pgsql: Fix memory leak when first string conversion fails

[nielsdos]

If the first string conversion fails, then i==0, but memory was still allocated for params. However, we skip freeing params when i==0.

[devnexen]

was it the "point of contention" ? in that case you can just change it place.

[nielsdos]

I don't understand what you mean

[devnexen]

if num_params == 0 then params array was never freed

[nielsdos]

Yes, e.g. if you exit here in the first iteration when i==0, then params is never freed:

php-src/ext/pgsql/pgsql.c

Lines 1130 to 1131 in 28ce1b0

	_php_pgsql_free_params(params, i);
	RETURN_THROWS();

Removing the num_params > 0 check fixes it. It is a useless check anyway: the loop will already check this and we should not do the check for freeing params.

[devnexen]

sure what I meant originally was just putting the efree(params); out of the if block would have worked as well but that s detail.

[nielsdos]

I see. That works too but since I'm touching the function anyway I thought I'd just remove the check

[devnexen]

Yes I just also saw your other PR, makes sense

[devnexen]

anyhow as long the fix is correct...