Fix GH-20194: null offset deprecation not emitted for writes #20238
+666
−2,110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not approving as it's still in draft, but looks good. Thanks for taking care of this! |
This is used by array_column(), the AST, and iterators
Girgias
force-pushed
the
8.5-null-offset
branch
from
19555de to
aca79f0
Compare
arnaud-lb
reviewed
Oct 20, 2025
Girgias
requested review from
bukka,
dstogov and
kamil-tekiela
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the patch from @nielsdos and split into different commits to explain what affects what.