Prevent some value copies in ext/xml to improve performance #20471
+11
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Nov 13, 2025
Comment on lines
1180
to
1182
| ) { \ | ||
| zend_string *method_name = zend_string_copy(parser_to_check->fcc_field.function_handler->common.function_name); \ | ||
| zend_string *method_name = parser_to_check->fcc_field.function_handler->common.function_name; \ | ||
| zend_fcc_dtor(&parser_to_check->fcc_field); \ |
Member
There was a problem hiding this comment.
Have you checked with a trampoline? As in that case the function name could be released via zend_fcc_dtor() no?
Member
Author
There was a problem hiding this comment.
I think you're right; at least when there are NUL bytes in the function name, zend_get_call_trampoline_func makes a new string. I'll revert this. Nice find.
ndossche
force-pushed
the
xml-reduce-copies
branch
from
764f7ba to
6ae0d25
Compare
devnexen
approved these changes
Nov 14, 2025
Girgias
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And to simplify some code