Skip to content

xml: Drop unused XML_GetCurrentByteCount() compatibility wrapper #20476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+2 −9
Merged

xml: Drop unused XML_GetCurrentByteCount() compatibility wrapper #20476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADING.INTERNALS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ PHP 8.6 INTERNALS UPGRADE NOTES
- ext/xml:
. Removed the XML_ExpatVersion() libxml compatibility wrapper,
as it was unused.
. Removed the XML_GetCurrentByteCount() libxml compatibility wrapper,
as it was unused and could return the wrong result.

========================
4. OpCode changes
Expand Down
8 changes: 0 additions & 8 deletions ext/xml/compat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,14 +644,6 @@ XML_GetCurrentByteIndex(XML_Parser parser)
(parser->parser->input->cur - parser->parser->input->base);
}

PHP_XML_API int
XML_GetCurrentByteCount(XML_Parser parser)
{
/* TODO: this is identical to ByteIndex; it should probably
* be different */
return (int) XML_GetCurrentByteIndex(parser);
}

PHP_XML_API void
XML_ParserFree(XML_Parser parser)
{
Expand Down
1 change: 0 additions & 1 deletion ext/xml/expat_compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ PHP_XML_API const XML_Char *XML_ErrorString(int);
PHP_XML_API int XML_GetCurrentLineNumber(XML_Parser);
PHP_XML_API int XML_GetCurrentColumnNumber(XML_Parser);
PHP_XML_API long XML_GetCurrentByteIndex(XML_Parser);
PHP_XML_API int XML_GetCurrentByteCount(XML_Parser);
PHP_XML_API void XML_ParserFree(XML_Parser);

#elif defined(HAVE_LIBEXPAT)
Expand Down