Fix GH-20483: ASAN stack overflow with small fiber.stack_size INI value. #20495
Conversation
|
@ndossche is the macos failure due to another libxml unlucky update ? looks like a nightmare. |
Zend/zend.c
Outdated
| static ZEND_INI_MH(OnUpdateFiberStackSize) /* {{{ */ | ||
| { | ||
| if (new_value) { | ||
| // taken from zend_get_fiber_stack_size() |
There was a problem hiding this comment.
I see... It's unfortunate that we would need to duplicate the code.
In that case, it's better to move this to zend_fibers.c where the existing minimum check is already written. That way we would avoid duplication.
Macos updated to libxml 2.15. When that released we had a lot of deprecation warnings. I reported in https://gitlab.gnome.org/GNOME/libxml2/-/issues/995 that there was no replacement for many of those APIs we rely on. Many APIs were undeprecated after that. However, those undeprecations haven't made it into a release yet. There's also an issue with one of the global settings that I didn't get around to yet. |
|
Why did this target 8.4 though, shouldn't this target 8.3 or am I missing something? |
|
I could not reproduce in 8.3 |
I see. I think in theory it can; so if I were in your position I'd merge it into 8.3 as well. |
|
alright |
2 participants
No description provided.