Fix GH-20491: SLES15 compile error with mbstring oniguruma #20499
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is specific to SLES15. Arguably this should be reported to them as it seems to me they meddled with the oniguruma source code. The definition in oniguruma.h on that platform looks like this (same as upstream): ```c ONIG_EXTERN int onig_error_code_to_str PV_((OnigUChar* s, int err_code, ...)); ``` Where `PV_` is defined as (differs): ```c ``` So that means that `HAVE_STDARG_PROTOTYPES` is unset. This can be set if we define `HAVE_STDARG_H`, which we can do because PHP requires at least C99 in which the header is always available. We could also use an autoconf check, but this isn't really necessary as it will always succeed.
youkidearitai
approved these changes
Nov 16, 2025
Contributor
youkidearitai
left a comment
youkidearitai
left a comment
There was a problem hiding this comment.
My local environment is good. So looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is specific to SLES15.
Arguably this should be reported to them as it seems to me they meddled with the oniguruma source code.
The definition in oniguruma.h on that platform looks like this (same as upstream):
Where
PV_is defined as (differs):So that means that
HAVE_STDARG_PROTOTYPESis unset. This can be set if we defineHAVE_STDARG_H,which we can do because PHP requires at least C99 in which the header is always available.
We could also use an autoconf check, but this isn't really necessary as it will always succeed.