Skip to content

Conversation

@ndossche
Copy link
Member

This is the first batch of changes to migrate away from deprecated APIs, fixes some deprecation warnings.

@devnexen
Copy link
Member

Is there more to it than deprecated fields ?

@devnexen
Copy link
Member

devnexen commented Nov 17, 2025

seems worth it to fix in the same move the input buffer part IMHO (~line 594)

@ndossche
Copy link
Member Author

Is there more to it than deprecated fields ?

Here we can easily avoid some of the direct field accesses by using (new) public APIs.
There's a remaining deprecation in the ext/libxml/libxml.c file that requires more complex changes.

There is also an issue I opened on the libxml repo about a deprecation that I see no full replacement for: https://gitlab.gnome.org/GNOME/libxml2/-/issues/1017

@ndossche
Copy link
Member Author

seems worth it to fix in the same move the input buffer part IMHO (~line 594)

That requires more thinking as that function needs to return a xmlParserInputBufferPtr

@devnexen
Copy link
Member

Is there more to it than deprecated fields ?

Here we can easily avoid some of the direct field accesses by using (new) public APIs. There's a remaining deprecation in the ext/libxml/libxml.c file that requires more complex changes.

There is also an issue I opened on the libxml repo about a deprecation that I see no full replacement for: https://gitlab.gnome.org/GNOME/libxml2/-/issues/1017

gosh :)

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright then

@ndossche ndossche closed this in 6054a90 Nov 18, 2025
jmarble pushed a commit to jmarble/php-src that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants