xml: Optimize attribute array construction #20515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes can't be numeric strings by the definition of the grammar, so don't bother with the symbol table stuff.
devnexen
approved these changes
Nov 17, 2025
Contributor
|
Is my guess right that this PR might reduce overhead when generating phpunit coverage xml reports? |
Girgias
approved these changes
Nov 18, 2025
Member
Author
No, this extension is an XML SAX parser that's unrelated to that coverage report generator. |
jmarble
pushed a commit
to jmarble/php-src
that referenced
this pull request
Nov 21, 2025
Attributes can't be numeric strings by the definition of the grammar, so don't bother with the symbol table stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes can't be numeric strings by the definition of the grammar, so don't bother with the symbol table stuff.