Skip to content

ext/soap: HTTP request micro optimisations. #20516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

ext/soap: HTTP request micro optimisations. #20516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ext/soap/php_http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,8 +1014,7 @@ int make_http_soap_request(
char *eqpos = strstr(cookie, "=");
char *sempos = strstr(cookie, ";");
if (eqpos != NULL && (sempos == NULL || sempos > eqpos)) {
smart_str name = {0};
int cookie_len;
size_t cookie_len;
zval zcookie;

if (sempos != NULL) {
Expand All @@ -1024,8 +1023,7 @@ int make_http_soap_request(
cookie_len = strlen(cookie)-(eqpos-cookie)-1;
}

smart_str_appendl(&name, cookie, eqpos - cookie);
smart_str_0(&name);
zend_string *name = zend_string_init(cookie, eqpos - cookie, false);

array_init(&zcookie);
add_index_stringl(&zcookie, 0, eqpos + 1, cookie_len);
Expand Down Expand Up @@ -1063,8 +1061,8 @@ int make_http_soap_request(
GC_ADDREF(uri->host);
}

zend_symtable_update(Z_ARRVAL_P(cookies), name.s, &zcookie);
smart_str_free(&name);
zend_symtable_update(Z_ARRVAL_P(cookies), name, &zcookie);
zend_string_release_ex(name, false);
}

cookie_itt = cookie_itt + cookie_len;
Expand Down