Skip to content

Fix GH-20528: Regression breaks mysql connexion using an IPv6 address… #20536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix GH-20528: Regression breaks mysql connexion using an IPv6 address… #20536

wants to merge 3 commits into from
+45 −3

Conversation

@remicollet
Copy link
Member

@remicollet remicollet commented Nov 20, 2025

… enclosed in square brackets

Notice: this is a minimal fix for the regression GH-20528
So GH-8978 is only partially fixed (missing IPv6 address enclosed in square brackets, ex [::1]:3306)

@remicollet remicollet requested review from ndossche and removed request for SakiTakamachi, bukka and kamil-tekiela November 20, 2025 02:01
remicollet referenced this pull request Nov 20, 2025
@ndossche
Fix GH-8978: MySQLi: SSL certificate verification fails (port doubled)
472f2fe 
If there are 2 ports, only the first is used.
However, then the certificate checking fails. So we drop the second port
if there is one.

Closes GH-20021.
@remicollet remicollet changed the base branch from master to PHP-8.3 November 20, 2025 02:08
@remicollet
Copy link
Member Author

remicollet commented Nov 20, 2025

Second commit handles IPv6 address enclosed in square brackets

EdouardCourty
EdouardCourty reviewed Nov 20, 2025
View reviewed changes
EdouardCourty
EdouardCourty reviewed Nov 20, 2025
View reviewed changes
@remicollet
Copy link
Member Author

remicollet commented Nov 20, 2025 •
edited
Loading

Tested locally with

$ export MYSQL_TEST_HOST=127.0.1
$ make test TESTS="--show-diff ext/mysqli/tests/mysqli_connect_port.phpt"

$ export MYSQL_TEST_HOST=[::1]
$ make test TESTS="--show-diff ext/mysqli/tests/mysqli_connect_port.phpt"

$ export MYSQL_TEST_HOST=name
$ make test TESTS="--show-diff ext/mysqli/tests/mysqli_connect_port.phpt"

ndossche
ndossche approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this. I believe the logic is right. I did some tests and it gives me the expected results.

@remicollet
Copy link
Member Author

remicollet commented Nov 21, 2025

Merged in PHP-8.3 as 9d71c1e and 769f319

@remicollet remicollet closed this Nov 21, 2025
jorgsowa referenced this pull request Nov 21, 2025
@remicollet
Fix GH-20528: Regression breaks mysql connexion using an IPv6 address…
9d71c1e 
… enclosed in square brackets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndossche ndossche ndossche approved these changes

+1 more reviewer

@EdouardCourty EdouardCourty EdouardCourty left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Extension: mysqli Extension: mysqlnd Waiting on RM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@remicollet @ndossche @EdouardCourty