xml: Use strlen() #20544
Merged
xml: Use strlen() #20544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Nov 20, 2025
|
|
||
| /* {{{ xml_xmlcharlen() */ | ||
| static int xml_xmlcharlen(const XML_Char *s) | ||
| static size_t xml_xmlcharlen(const XML_Char *s) |
Member
There was a problem hiding this comment.
seems to me it becomes of very little value no ?
Member
Author
There was a problem hiding this comment.
Yeah, but it hides the cast, so still has some
Member
There was a problem hiding this comment.
as you want ... but there is only two usages so far :)
Member
Author
There was a problem hiding this comment.
That's a valid point. In the end I don't think it really matters that much.
devnexen
approved these changes
Nov 20, 2025
jmarble
pushed a commit
to jmarble/php-src
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.