Skip to content

ext/posix: validate mode argument in posix_access #21104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arshidkv12 wants to merge 8 commits into from
+63 −0
Closed

ext/posix: validate mode argument in posix_access #21104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df7af12
posix: validate mode argument in posix_access
arshidkv12 Jan 31, 2026
7d8e035
posix: validate mode argument in posix_access
arshidkv12 Jan 31, 2026
6e2db41
posix: validate mode argument in posix_access
arshidkv12 Jan 31, 2026
26cec7b
posix: validate mode argument in posix_access
arshidkv12 Feb 1, 2026
b545077
posix: validate mode argument in posix_access
arshidkv12 Feb 1, 2026
2ea77e5
posix_access_flags
arshidkv12 Feb 4, 2026
97d8cb4
ext/posix: Edit clean section
arshidkv12 Feb 6, 2026
4e8aaa6
ext/posix: suppress unlink() warning in PHPT
arshidkv12 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ext/posix/posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,15 @@ PHP_FUNCTION(posix_access)
RETURN_FALSE;
}

if (mode < 0 || (mode & ~(F_OK | R_OK | W_OK | X_OK))) {
zend_argument_value_error(
2,
"must be a bitmask of POSIX_F_OK, POSIX_R_OK, POSIX_W_OK, and POSIX_X_OK"
);
efree(path);
RETURN_THROWS();
}

ret = access(path, mode);
efree(path);

Expand Down
54 changes: 54 additions & 0 deletions ext/posix/tests/posix_access_flags.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
--TEST--
posix_access() flag (mode) validation
--SKIPIF--
<?php
if (!function_exists("posix_access")) {
die("skip no posix_access()");
}
?>
--FILE--
<?php

$dir = __DIR__;
$testfile = "$dir/testfile.txt";

// Create a temporary file for valid access tests
file_put_contents($testfile, "hello");

try {
posix_access($testfile, -1);
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
}

try {
posix_access($testfile, 01000); // S_ISVTX bit (sticky)
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
}

try {
posix_access($testfile, 02000); // S_ISGID bit
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
}

if (posix_access($testfile, POSIX_R_OK | POSIX_W_OK)) {
echo "Read/write access OK\n";
}

if (posix_access($testfile, POSIX_F_OK)) {
echo "File exists OK\n";
}

?>
--CLEAN--
<?php
@unlink(__DIR__ . '/testfile.txt');
?>
--EXPECTF--
posix_access(): Argument #2 ($flags) must be a bitmask of POSIX_F_OK, POSIX_R_OK, POSIX_W_OK, and POSIX_X_OK
posix_access(): Argument #2 ($flags) must be a bitmask of POSIX_F_OK, POSIX_R_OK, POSIX_W_OK, and POSIX_X_OK
posix_access(): Argument #2 ($flags) must be a bitmask of POSIX_F_OK, POSIX_R_OK, POSIX_W_OK, and POSIX_X_OK
Read/write access OK
File exists OK
Loading