Skip to content

Conversation

beberlei
Copy link
Contributor

@beberlei beberlei commented Apr 15, 2020

This would be super helpful while developing as you could immediately get a gdb session for a failed test (if its a segfault for example). Example: ./Zend/tests/001.gdb.sh

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds useful...

@nikic
Copy link
Member

nikic commented Apr 17, 2020

I'm wondering it may make sense to generalize this, by allowing a general prefix to the sh script. E.g. what I usually do as first step is USE_ZEND_ALLOC=0 valgrind ..., then gdb --args ... if that doesn't help (and rr record ... as last resort).

@beberlei
Copy link
Contributor Author

Maybe make the mode an argument to the script instead, that way we dont pollute the filesystem: ./001.sh gdb or ./001.sh valgrind etc

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@beberlei
Copy link
Contributor Author

Merged in ec88bbc

@beberlei beberlei closed this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants