Track JIT successes and failures for opcache_get_status #5806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been quite a few JIT benchmarks lately. It would be interesting to know how many functions actually make use of the JIT in large repositories. This PR track successes and failures and returns them in
opcache_get_status
. Naming is a little verbose, let me know if that's ok. Also, it would obviously be more useful if we knew which functions failed compiling but that would probably be too expensive. This PR might be too simplistic, let me know if there's something I didn't handle properly./ping @dstogov