Skip to content

Conversation

remicollet
Copy link
Member

@remicollet remicollet commented Oct 7, 2020

Running php --re standard:

Before:

    Function [ <internal:standard> function compact ] {

      - Parameters [2] {
        Parameter #0 [ <required> $var_name ]
        Parameter #1 [ <optional> ...$var_names = <default> ]
      }
      - Return [ array ]
    }

After:

    Function [ <internal:standard> function compact ] {

      - Parameters [2] {
        Parameter #0 [ <required> $var_name ]
        Parameter #1 [ <optional> ...$var_names ]
      }
      - Return [ array ]

And by consistency with zend_get_function_declaration which uses:

if (i >= required && !ZEND_ARG_IS_VARIADIC(arg_info)) {

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@remicollet
Copy link
Member Author

Applied in 91f47ee

@remicollet remicollet closed this Oct 7, 2020
@remicollet remicollet deleted the issue-variadic branch October 7, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants