Change the order of properties used for var_dump(), serialize(), comparison, etc #6736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arison, etc. Now properties are ordered according to their layout in zend_object structure.
|
@nikic please take a look. This is a breake, but a proper breake ... |
nikic
approved these changes
Mar 1, 2021
|
This was merged in b0c7ea4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now properties are ordered according to order of declaration and inheritance (properties of base class are gong to be before the child properties). This order is also consistent with layout of properties in zend_object structure.
This order is more consistent by its own.
This also allows simple and consistent implementations of FOREACH, serialize(), json_encode(), etc without rebuilding properties HashTable.