Fixes typo in release.inc #1090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typo in function name and comments.
jubayerarefin
requested review from
saundefined and
sy-records
as code owners
|
🚀 Regression report for commit ea8633e is at https://web-php-regression-report-pr-1090.preview.thephp.foundation |
|
🚀 Preview for commit ea8633e can be found at https://web-php-pr-1090.preview.thephp.foundation |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sy-records
requested changes
Oct 11, 2024
| fclose($this->logFile); | ||
| unlink('/tmp/logfile'); | ||
| } | ||
| } | ||
|
|
||
| // The log file will never be removed, because the | ||
| // method name was mistyped (taerDown vs tearDown). | ||
| // method name was mistyped (tearDown vs tearDown). |
There was a problem hiding this comment.
Thanks your PR.
But It's intentional, not typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typo in function name and comments.
Changes
taerDowntotearDown