Skip to content

Create Devcontainer config #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2025
Merged

Create Devcontainer config #1189

merged 5 commits into from
Jul 31, 2025

Conversation

garrettw
Copy link
Contributor

Picks up where #995 left off, since the idea didn't seem objectionable.

TimWolla
TimWolla reviewed Jul 27, 2025
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense to me. Thank you!

@garrettw garrettw requested a review from sgolemon as a code owner July 27, 2025 16:26
TimWolla
TimWolla approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contents LGTM.

derickr
derickr reviewed Jul 30, 2025
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a question.

@derickr derickr merged commit b53f8f1 into php:master Jul 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr derickr left review comments

@saundefined saundefined Awaiting requested review from saundefined saundefined is a code owner

@sy-records sy-records Awaiting requested review from sy-records sy-records is a code owner

@sgolemon sgolemon Awaiting requested review from sgolemon sgolemon is a code owner

+1 more reviewer

@TimWolla TimWolla TimWolla approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettw @derickr @TimWolla