Trying to simplify coverage cookie test

Author: giorgiosironi

PHPUnit/Extensions/SeleniumCommon/RemoteCoverage.php

@@ -23,7 +23,7 @@ public function get()
                 if (is_array($coverageData)) {
                     return $this->matchLocalAndRemotePaths($coverageData);
                 } else {
-                    throw new Exception('Empty or invalid code coverage data received from url "' . $url . '"');
+                    throw new Exception('Empty or invalid code coverage data received from url "' . $url . '" (' . var_export($buffer, true) . ')');
                 }
             }
         }

Tests/Selenium2TestCase/Coverage/CookieTest.php

@@ -2,12 +2,7 @@
 class Tests_Selenium2TestCase_Coverage_CookieTest extends Tests_Selenium2TestCase_BaseTestCase
 {
     // this is a dummy URL (no server at that port), but Firefox still sets domain cookie, which is what's needed
-    protected $coverageScriptUrl = 'http://127.0.0.1:8081/';
-
-    public static function setUpBeforeClass()
-    {
-        self::shareSession(true);
-    }
+    protected $coverageScriptUrl = 'http://127.0.0.1:8082';
 
     public function run(PHPUnit_Framework_TestResult $result = NULL)
     {
@@ -24,12 +19,12 @@ public function run(PHPUnit_Framework_TestResult $result = NULL)
         $result->getCodeCoverage()->clear();
     }
 
-    protected function getTestIdCookie ()
+    protected function getTestIdCookie()
     {
         return $this->prepareSession()->cookie()->get('PHPUNIT_SELENIUM_TEST_ID');
     }
 
-    public function testTestIdCookieIsSet ()
+    public function testTestIdCookieIsSet()
     {
         $this->url('/');
         return $this->getTestIdCookie();
@@ -38,7 +33,7 @@ public function testTestIdCookieIsSet ()
     /**
      * @depends testTestIdCookieIsSet
      */
-    public function testTestsHaveUniqueTestIdCookies ($previousTestIdCookie)
+    public function testTestsHaveUniqueTestIdCookies($previousTestIdCookie)
     {
         $this->url('/');
         $this->assertNotEquals($this->getTestIdCookie(), $previousTestIdCookie);

selenium-1-tests/coverage/dummy.txt

@@ -1 +1 @@
-a:3:{s:85:"/home/giorgio/code/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/ExitHandler.php";a:2:{s:3:"md5";s:32:"9da156828a8b6591d6905664624e29fb";s:8:"coverage";a:9:{i:10;i:1;i:18;i:1;i:19;i:1;i:26;i:-1;i:27;i:-1;i:28;i:-1;i:29;i:-1;i:30;i:-1;i:32;i:1;}}s:83:"/home/giorgio/code/phpunit-selenium/Tests/Selenium2TestCase/Coverage/DummyClass.php";a:2:{s:3:"md5";s:32:"7c8088a34547c159e7bf27f792211bb6";s:8:"coverage";a:6:{i:3;i:1;i:6;i:1;i:7;i:-2;i:11;i:-1;i:12;i:-2;i:14;i:1;}}s:83:"/home/giorgio/code/phpunit-selenium/Tests/Selenium2TestCase/Coverage/singleFile.php";a:2:{s:3:"md5";s:32:"01983b91b1db9d6d59e48111c6b0fe5a";s:8:"coverage";a:4:{i:5;i:1;i:6;i:1;i:7;i:1;i:9;i:1;}}}
+a:3:{s:85:"/home/giorgio/code/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/ExitHandler.php";a:2:{s:3:"md5";s:32:"9da156828a8b6591d6905664624e29fb";s:8:"coverage";a:9:{i:10;i:1;i:18;i:1;i:19;i:1;i:26;i:-1;i:27;i:-1;i:28;i:-1;i:29;i:-1;i:30;i:-1;i:32;i:1;}}s:83:"/home/giorgio/code/phpunit-selenium/Tests/Selenium2TestCase/Coverage/DummyClass.php";a:2:{s:3:"md5";s:32:"7c8088a34547c159e7bf27f792211bb6";s:8:"coverage";a:6:{i:3;i:1;i:6;i:1;i:7;i:-2;i:11;i:-1;i:12;i:-2;i:14;i:1;}}s:83:"/home/giorgio/code/phpunit-selenium/Tests/Selenium2TestCase/Coverage/singleFile.php";a:2:{s:3:"md5";s:32:"01983b91b1db9d6d59e48111c6b0fe5a";s:8:"coverage";a:4:{i:5;i:1;i:6;i:1;i:7;i:1;i:9;i:1;}}}