PHP8-RC1 support #10

nanasess · 2020-10-01T07:35:28Z

Fix warnings below:

PHP Warning: Private methods cannot be final as they are never overridden by other classes
Fix ReflectionException
Error message changed in PHP8 or later
string to number comparison changed in PHP8 or later
- see https://wiki.php.net/rfc/string_to_number_comparison

`PHP Warning: Private methods cannot be final as they are never overridden by other classes`

use array_values()

nanasess added 4 commits October 1, 2020 16:29

Fix warnings

86debaf

`PHP Warning: Private methods cannot be final as they are never overridden by other classes`

Fix ReflectionException

4716039

use array_values()

Error message changed in PHP8 or later

57584c3

string to number comparison changed in PHP8 or later

6053222

nanasess changed the title ~~Remove final keywords~~ PHP8-RC1 support Oct 16, 2020

nanasess added 3 commits October 16, 2020 19:26

xdebug_disable() is obsolete

f0c52a8

xdebug_disable() is obsolete

9163c3e

PHP7 is required

d9b2ad6

nanasess force-pushed the fix-final-private branch from b0bb254 to d9b2ad6 Compare October 16, 2020 10:57

nanasess merged commit b9db698 into php5friends:4.8 Oct 17, 2020

Provide feedback