Feature/v3 configuration #1932
Merged
Feature/v3 configuration #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This pr is blocked by some internal discussions and tests of a new plugin structure. |
Member
|
If there's a |
ashnazg
reviewed
Apr 26, 2018
| */ | ||
| public function execute($command, callable $next) | ||
| { | ||
| var_dump($command->getFile()->path()); |
Member
Author
There was a problem hiding this comment.
Saw that one to. Fixing it currently 😃
ashnazg
reviewed
Apr 26, 2018
Member
ashnazg
left a comment
ashnazg
left a comment
There was a problem hiding this comment.
Conflict showing for composer.lock.
Good bit of commented-out code still in here.
Two questions of my own (.env and var_dump).
Note that I have no real experience in DICs, so I can't review the logic here. If it runs correctly in your tests, that's good enough for me.
I could probably follow up later to put in additional strict typing, since this already has so much change in it.
In this change I have replaced Cilex with Symfony 4. In this change I have introduced a compatibility layer so that third-party's can integrate with minimal effort. An important thing to note is that this layer should be temporary and there is not a 100% guarantue. For one; order now matters and this may cause errors for some third-parties.
In preparation to refactor the commands I moved them all to a separate namespace centralized in the application.
By moving the business logic of parser and transform commands we are able to reuse it without any strange hacks in multiple commands. Configuration is now completely provided as an array from the configuration factory.
Pass the parser instance to cache middleware so it can check if the force flag was enabled. Because this triggers a circular dependency I introduced parser as a lazy service.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a follow up on pr #1940.
It replaces the configuration of phpdocumentor with the new v3 config setup. A lot of refactoring was needed to accomplish this. I moved the commands to stages of a pipeline, the commands are refactored to pipeline only.