Use cache folder in config for Twig #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the Twig cache files were stored in the system's temp directory. Although this works in many cases, it may lead to issues when different projects have different twig files. This change includes two things: 1. Change pipelines to read stages using tags 2. Introduce a new stage that sets the Twig cache folder to use a subfolder of the configured cache folder. By changing the pipelines we can dynamically introduce a new stage in the pipeline with a specific priority. This new stage reads the configuration and preconfigures the twig service.
Member
Author
|
Fixes #1605 |
jaapio
approved these changes
Sep 4, 2018
Member
jaapio
left a comment
jaapio
left a comment
There was a problem hiding this comment.
Just a simple thing to check.
I really like the much cleaner approach of creating the pipelines. and stages.
If you just check the twig env types. This one looks good to me.
|
|
||
| namespace phpDocumentor\Plugin\Twig\Stage; | ||
|
|
||
| use Twig\Environment; |
Member
There was a problem hiding this comment.
Is this the right type? Since the twig writer expects a twig_environment?
Member
Author
There was a problem hiding this comment.
Twig_Environment and Twig\Environment are the same classes :) One is an alias
jaapio
deleted the
feature/use-project-cacehe-folder-for-twig-instead-of-system-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the Twig cache files were stored in the system's temp
directory. Although this works in many cases, it may lead to issues when
different projects have different twig files.
This change includes two things:
of the configured cache folder.
By changing the pipelines we can dynamically introduce a new stage in the
pipeline with a specific priority. This new stage reads the configuration
and preconfigures the twig service.