After review 0

Author: tatevikg1

src/Identity/Request/UpdateAdministratorRequest.php

@@ -72,7 +72,7 @@ class UpdateAdministratorRequest implements RequestInterface
     public ?string $email = null;
 
     #[Assert\Type('bool')]
-    public ?bool $superAdmin = null;
+    public ?bool $superUser = null;
 
     /**
      * Array of privileges where keys are privilege names (from PrivilegeFlag enum) and values are booleans.
@@ -93,7 +93,7 @@ public function getDto(): UpdateAdministratorDto
             loginName: $this->loginName,
             password: $this->password,
             email: $this->email,
-            superAdmin: $this->superAdmin,
+            superAdmin: $this->superUser,
             privileges: $this->privileges
         );
     }

src/Identity/Serializer/AdminAttributeDefinitionNormalizer.php

@@ -38,7 +38,6 @@ public function normalize($object, string $format = null, array $context = []):
             'list_order' => $object->getListOrder(),
             'default_value' => $object->getDefaultValue(),
             'required' => $object->isRequired(),
-            'table_name' => $object->getTableName(),
         ];
     }
 

src/Identity/Serializer/AdminAttributeValueNormalizer.php

@@ -12,7 +12,7 @@
     schema: 'AdminAttributeValue',
     properties: [
         new OA\Property(property: 'administrator', ref: '#/components/schemas/Administrator'),
-        new OA\Property(property: 'definition', ref: '#/components/schemas/AttributeDefinition'),
+        new OA\Property(property: 'definition', ref: '#/components/schemas/AdminAttributeDefinition'),
         new OA\Property(property: 'value', type: 'string', example: 'United States'),
     ],
     type: 'object'

src/Identity/Serializer/AdministratorNormalizer.php

@@ -17,6 +17,7 @@
         new OA\Property(property: 'login_name', type: 'string', example: 'admin'),
         new OA\Property(property: 'email', type: 'string', format: 'email', example: 'admin@example.com'),
         new OA\Property(property: 'super_user', type: 'boolean', example: true),
+        new OA\Property(property: 'privileges', type: 'array', items: new OA\Items(type: 'string')),
         new OA\Property(
             property: 'created_at',
             type: 'string',
@@ -42,7 +43,7 @@ public function normalize($object, string $format = null, array $context = []):
             'id' => $object->getId(),
             'login_name' => $object->getLoginName(),
             'email' => $object->getEmail(),
-            'super_admin' => $object->isSuperUser(),
+            'super_user' => $object->isSuperUser(),
             'privileges' => $object->getPrivileges()->all(),
             'created_at' => $object->getCreatedAt()?->format(DateTimeInterface::ATOM),
         ];

src/Messaging/Request/Message/MessageScheduleRequest.php

@@ -13,14 +13,14 @@
     required: ['embargo'],
     properties: [
         new OA\Property(property: 'embargo', type: 'string', format: 'date-time', example: '2025-04-17 09:00:00'),
-        new OA\Property(property: 'repeat_interval', type: 'string', example: '24 hours'),
+        new OA\Property(property: 'repeat_interval', type: 'integer', example: '24 hours'),
         new OA\Property(
             property: 'repeat_until',
             type: 'string',
             format: 'date-time',
             example: '2025-04-30T00:00:00+04:00'
         ),
-        new OA\Property(property: 'requeue_interval', type: 'string', example: '12 hours'),
+        new OA\Property(property: 'requeue_interval', type: 'integer', example: '12 hours'),
         new OA\Property(
             property: 'requeue_until',
             type: 'string',

src/Messaging/Serializer/ListMessageNormalizer.php

@@ -28,6 +28,7 @@
             example: '2022-12-01T10:00:00Z'
         ),
     ],
+    type: 'object'
 )]
 class ListMessageNormalizer implements NormalizerInterface
 {

src/Subscription/Serializer/AttributeDefinitionNormalizer.php

@@ -13,11 +13,10 @@
     properties: [
         new OA\Property(property: 'id', type: 'integer', example: 1),
         new OA\Property(property: 'name', type: 'string', example: 'Country'),
-        new OA\Property(property: 'type', type: 'string', example: 'checkbox'),
+        new OA\Property(property: 'type', type: 'string', example: 'checkbox', nullable: true),
         new OA\Property(property: 'list_order', type: 'integer', example: 12),
         new OA\Property(property: 'default_value', type: 'string', example: 'United States'),
         new OA\Property(property: 'required', type: 'boolean', example: true),
-        new OA\Property(property: 'table_name', type: 'string', example: 'list_attributes'),
         new OA\Property(
             property: 'options',
             type: 'array',

src/Subscription/Serializer/SubscriberHistoryNormalizer.php

@@ -19,7 +19,7 @@
             format: 'date-time',
             example: '2022-12-01T10:00:00Z'
         ),
-        new OA\Property(property: 'summery', type: 'string', example: 'Added by admin'),
+        new OA\Property(property: 'summary', type: 'string', example: 'Added by admin'),
         new OA\Property(property: 'detail', type: 'string', example: 'Added with add-email on test'),
         new OA\Property(property: 'system_info', type: 'string', example: 'HTTP_USER_AGENT = Mozilla/5.0'),
     ],
@@ -40,7 +40,7 @@ public function normalize($object, string $format = null, array $context = []):
             'id' => $object->getId(),
             'ip' => $object->getIp(),
             'created_at' => $object->getCreatedAt()->format('Y-m-d\TH:i:sP'),
-            'summery' => $object->getSummary(),
+            'summary' => $object->getSummary(),
             'detail' => $object->getDetail(),
             'system_info' => $object->getSystemInfo(),
         ];