Do not render PHP 8 promoted properties

Author: dantleech

composer.json

@@ -12,7 +12,7 @@
         "php": "^7.3",
         "microsoft/tolerant-php-parser": "~0.0.1",
         "phpactor/text-document": "^1.2.2",
-        "phpactor/worse-reflection": "~0.2",
+        "phpactor/worse-reflection": "~0.4.4",
         "twig/twig": "^2.4"
     },
     "require-dev": {

lib/Adapter/WorseReflection/WorseBuilderFactory.php

@@ -5,6 +5,8 @@
 use Phpactor\CodeBuilder\Domain\BuilderFactory;
 use Phpactor\TextDocument\TextDocument;
 use Phpactor\TextDocument\TextDocumentBuilder;
+use Phpactor\WorseReflection\Core\Reflection\ReflectionClass;
+use Phpactor\WorseReflection\Core\Reflection\ReflectionTrait;
 use Phpactor\WorseReflection\Reflector;
 use Phpactor\CodeBuilder\Domain\Builder\SourceCodeBuilder;
 use Phpactor\WorseReflection\Core\Reflection\ReflectionProperty;
@@ -67,9 +69,12 @@ private function build(string $type, SourceCodeBuilder $builder, ReflectionClass
         $classBuilder = $builder->$type($reflectionClass->name()->short());
         $builder->namespace($reflectionClass->name()->namespace());
 
-        if ($reflectionClass->isClass() || $reflectionClass->isTrait()) {
-            // TODO: Worse reflection doesn't support ->belongingTo properties
+        if ($reflectionClass instanceof ReflectionClass || $reflectionClass instanceof ReflectionTrait) {
             foreach ($reflectionClass->properties()->belongingTo($reflectionClass->name()) as $property) {
+                assert($property instanceof ReflectionProperty);
+                if ($property->isPromoted()) {
+                    continue;
+                }
                 $this->buildProperty($classBuilder, $property);
             }
         }

phpstan-baseline.neon

@@ -395,11 +395,6 @@ parameters:
 			count: 1
 			path: lib/Adapter/WorseReflection/WorseBuilderFactory.php
 
-		-
-			message: "#^Call to an undefined method Phpactor\\\\WorseReflection\\\\Core\\\\Reflection\\\\ReflectionClassLike\\:\\:properties\\(\\)\\.$#"
-			count: 1
-			path: lib/Adapter/WorseReflection/WorseBuilderFactory.php
-
 		-
 			message: "#^Parameter \\#2 \\$method of method Phpactor\\\\CodeBuilder\\\\Adapter\\\\WorseReflection\\\\WorseBuilderFactory\\:\\:buildMethod\\(\\) expects Phpactor\\\\WorseReflection\\\\Core\\\\Reflection\\\\ReflectionMethod, Phpactor\\\\WorseReflection\\\\Core\\\\Reflection\\\\ReflectionMember given\\.$#"
 			count: 1

tests/Adapter/WorseReflection/WorseBuilderFactoryTest.php

@@ -223,6 +223,12 @@ public function testInterfaceWithMethodParameters()
         $this->assertEquals('foo', (string) $source->interfaces()->first()->methods()->get('hello')->parameters()->get('foo')->name());
     }
 
+    public function testDoesNotBuildPHP8PromotedProperties(): void
+    {
+        $source = $this->build('<?php class Foobar { function __construct(private $foobar){}}');
+        self::assertEquals(0, $source->classes()->first()->properties()->count());
+    }
+
     private function build(string $source): SourceCode
     {
         $reflector = ReflectorBuilder::create()