Skip to content

Conversation

@iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Jun 30, 2024

Added ACP options to Board Settings for progressive web applications. These are optional but are where you can set a custom short name and the small and large icons.

Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro force-pushed the progressive-web-app branch from c173806 to e952d79 Compare June 30, 2024 19:23
@iMattPro iMattPro requested a review from rxu June 30, 2024 19:39
iMattPro added 3 commits June 30, 2024 14:43
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro
Copy link
Contributor Author

@marc1706 Experimenting with something else here. On iOS devices, web push notifications don't work unless the site is a "Progressive Web Application." That just means it needs some meta tags, some optional touch screen app icons, and a manifest.json file. This PR is looking to add that to the extension, which if works out, should probably go into the core too.

iMattPro added 5 commits June 30, 2024 16:13
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro force-pushed the progressive-web-app branch from 0541991 to e969e6b Compare July 1, 2024 05:27
iMattPro added 2 commits July 1, 2024 06:43
Signed-off-by: Matt Friedman <maf675@gmail.com>
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro force-pushed the progressive-web-app branch from 2fd5374 to 2fee530 Compare July 1, 2024 14:09
@iMattPro iMattPro removed the WIP 🚧 label Jul 1, 2024
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro force-pushed the progressive-web-app branch from b94e18b to 535af69 Compare July 1, 2024 22:22
Signed-off-by: Matt Friedman <maf675@gmail.com>
@iMattPro iMattPro force-pushed the progressive-web-app branch from 535af69 to 2b77944 Compare July 1, 2024 23:03
@iMattPro iMattPro merged commit f6ad9a3 into phpbb-extensions:main Jul 2, 2024
@iMattPro iMattPro deleted the progressive-web-app branch July 2, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants