Added move command #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
i would add something along "Keep in mind that the parent node of the destination path must already exist."
Member
|
looks good to me. only have input on the doc improvement - apart from the one above, we might also remind people somewhere that this can also be used to rename a node, as you move including the node name. |
|
may I ask why you guys use the session to move a node and not the odm? Having events fire would be a plus imo |
Member
|
this is in the phpcr-utils, not phpcr-odm. indeed we could have a doctrine:phpcr:document:move command |
Member
Author
|
Updated. |
This was referenced Apr 29, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.