Skip to content

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 19, 2018

@ibennetch
Copy link
Member

Needing this seems contrary to standard *nix development principals, but I have no problem adding it and it seems to be the right thing to do.

From the Debian bug report, it looks like there's a patch to fix this in the Debian package, so even aside from us merging this, hopefully it will be fixed in Debian soon.

Copy link
Member

@ibennetch ibennetch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J0WI
Copy link
Contributor Author

J0WI commented Nov 20, 2018

This is just a "backport" of the fix in the docker-library:
https://github.com/search?q=org%3Adocker-library+gpg-batch&type=Commits

@ibennetch ibennetch merged commit 56806ec into phpmyadmin:master Nov 22, 2018
@ibennetch
Copy link
Member

Merged in to master, thanks. I'll look to create a new Docker release in the next few days incorporating this (and probably your other pull request as well).

@ibennetch ibennetch self-assigned this Nov 22, 2018
@J0WI J0WI deleted the gpg-batch branch November 22, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants