Skip to content

Fetch latest version from api #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ibennetch merged 1 commit into from
Jun 8, 2019
Merged

Fetch latest version from api #215

ibennetch merged 1 commit into from
Jun 8, 2019

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented Mar 29, 2019

From #200 (comment)

I wonder if there's a way to update the version information in one place instead of needing to update four files on each new release.

Here we go.

cc @ibennetch

williamdes
williamdes approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J0WI
Copy link
Contributor Author

J0WI commented Apr 24, 2019

🏓 @ibennetch

@ibennetch ibennetch merged commit e670276 into phpmyadmin:master Jun 8, 2019
@J0WI J0WI deleted the update-version branch June 8, 2019 17:43
@ibennetch
Copy link
Member

ibennetch commented Jun 8, 2019

I finally merged this, thanks for your work!

@ibennetch ibennetch self-assigned this Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@ibennetch ibennetch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J0WI @ibennetch @williamdes