Skip to content

Mutator generates !! code #12

@ondrejmirtes

Description

@ondrejmirtes

This change in phpstan-doctrine doesn't seem great:

-        if (!(new ObjectType(QueryBuilder::class))->isSuperTypeOf($scope->getType($queryBuilderNode))->yes()) {
+        if (!!(new ObjectType(QueryBuilder::class))->isSuperTypeOf($scope->getType($queryBuilderNode))->no()) {

No human would write it like that 😊

Should be instead:

+        if ((new ObjectType(QueryBuilder::class))->isSuperTypeOf($scope->getType($queryBuilderNode))->no()) {

//cc @staabm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions