Skip to content

interessting that PHPStan needs 17-18 seconds to re-analyze only 6 files #16

@staabm

Description

@staabm

interessting that PHPStan needs 17-18 seconds to re-analyze only 6 files

10) /home/runner/work/build-infection/build-infection/src/Type/Doctrine/Query/QueryResultTypeWalker.php:930    [M] PHPStan\Infection\TrinaryLogicMutator [ID] 868c978753abd210075c3d2f3cb7405a

@@ @@
             $result = $this->createFloat($containsNull);
         } elseif ($typeNoNull->isNumericString()->yes()) {
             $result = $this->createNumericString($containsNull, $typeNoNull->isLowercaseString()->yes(), $typeNoNull->isUppercaseString()->yes());
-        } elseif ($typeNoNull->isString()->yes()) {
+        } elseif (!$typeNoNull->isString()->no()) {
             $result = $this->createString($containsNull, $typeNoNull->isLowercaseString()->yes(), $typeNoNull->isUppercaseString()->yes());
         } else {
             $result = $type;

$ '/home/runner/work/build-infection/build-infection/vendor/bin/phpstan' '--tmp-file=/tmp/infection/mutant.868c978753abd210075c3d2f3cb7405a.infection.php' '--instead-of=/home/runner/work/build-infection/build-infection/src/Type/Doctrine/Query/QueryResultTypeWalker.php' '--configuration=/tmp/infection/phpstan.868c978753abd210075c3d2f3cb7405a.infection.neon' '--error-format=json' '--no-progress' '-vv'
  {"totals":{"errors":0,"file_errors":1},"files":{"/home/runner/work/build-infection/build-infection/src/Type/Doctrine/Query/QueryResultTypeWalker.php":{"errors":1,"messages":[{"message":"Strict comparison using === between 'pdo_pgsql' and 'pdo_pgsql' will always evaluate to true.","line":1691,"ignorable":true,"identifier":"identical.alwaysTrue"}]}},"errors":[]}
  
  Result cache restored. 6 files will be reanalysed.
  Result cache was not saved because of --tmp-file and --instead-of CLI options passed (editor mode).
  Elapsed time: 17 seconds
  Used memory: 194.5 MB

Originally posted by @staabm in #11 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions