Skip to content

Conversation

@staabm
Copy link
Collaborator

@staabm staabm commented Nov 3, 2025

closes #24

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also one more thought: we shouldn't mutate $a->isSuperTypeOf($b)->maybe() because at that point the sides are interswitchable.

@staabm
Copy link
Collaborator Author

staabm commented Nov 3, 2025

Also one more thought: we shouldn't mutate $a->isSuperTypeOf($b)->maybe() because at that point the sides are interswitchable.

I did not find a single use of this pattern in phpstan-src

grafik

@staabm staabm marked this pull request as ready for review November 3, 2025 07:55
@staabm staabm force-pushed the issupertypeof branch 3 times, most recently from be4fc19 to 770960f Compare November 3, 2025 10:18
@ondrejmirtes
Copy link
Member

Conflicts here

@staabm staabm merged commit 6f3df78 into 1.x Nov 3, 2025
17 checks passed
@staabm staabm deleted the issupertypeof branch November 11, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mutation: switch isSuperTypeOf callee and argument

3 participants