Compute allowedArrayType only once

Author: VincentLanglet

src/Rules/Arrays/InvalidKeyInArrayDimFetchRule.php

@@ -58,18 +58,18 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$phpVersion = $this->phpVersion;
+		$allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion);
 		$dimensionType = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$node->dim,
 			'',
-			static fn (Type $dimType): bool => AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimType)->yes(),
+			static fn (Type $dimType): bool => $allowedArrayKeys->isSuperTypeOf($dimType)->yes(),
 		)->getType();
 		if ($dimensionType instanceof ErrorType) {
 			return [];
 		}
 
-		$isSuperType = AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimensionType);
+		$isSuperType = $allowedArrayKeys->isSuperTypeOf($dimensionType);
 		if ($isSuperType->yes() || ($isSuperType->maybe() && !$this->reportMaybes)) {
 			return [];
 		}

src/Rules/Arrays/InvalidKeyInArrayItemRule.php

@@ -39,18 +39,18 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$phpVersion = $this->phpVersion;
+		$allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion);
 		$dimensionType = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$node->key,
 			'',
-			static fn (Type $dimType): bool => AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimType)->yes(),
+			static fn (Type $dimType): bool => $allowedArrayKeys->isSuperTypeOf($dimType)->yes(),
 		)->getType();
 		if ($dimensionType instanceof ErrorType) {
 			return [];
 		}
 
-		$isSuperType = AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimensionType);
+		$isSuperType = $allowedArrayKeys->isSuperTypeOf($dimensionType);
 		if ($isSuperType->yes()) {
 			return [];
 		}