Named arguments - cannot use positional after named

Author: ondrejmirtes

src/Rules/FunctionCallParametersCheck.php

@@ -83,8 +83,12 @@ public function check(
 		/** @var array<int, \PhpParser\Node\Arg> $args */
 		$args = $funcCall->args;
 		$hasNamedArguments = false;
+		$errors = [];
 		foreach ($args as $i => $arg) {
 			$type = $scope->getType($arg->value);
+			if ($hasNamedArguments && $arg->name === null) {
+				$errors[] = RuleErrorBuilder::message('Named argument cannot be followed by a positional argument.')->line($arg->getLine())->nonIgnorable()->build();
+			}
 			if ($arg->name !== null) {
 				$hasNamedArguments = true;
 			}
@@ -129,8 +133,6 @@ public function check(
 			];
 		}
 
-		$errors = [];
-
 		if ($hasNamedArguments && !$this->phpVersion->supportsNamedArguments()) {
 			$errors[] = RuleErrorBuilder::message('Named arguments are supported only on PHP 8.0 and later.')->nonIgnorable()->build();
 		}

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -27,13 +27,16 @@ class CallMethodsRuleTest extends \PHPStan\Testing\RuleTestCase
 	/** @var bool */
 	private $checkExplicitMixed = false;
 
+	/** @var int */
+	private $phpVersion = PHP_VERSION_ID;
+
 	protected function getRule(): Rule
 	{
 		$broker = $this->createReflectionProvider();
 		$ruleLevelHelper = new RuleLevelHelper($broker, $this->checkNullables, $this->checkThisOnly, $this->checkUnionTypes, $this->checkExplicitMixed);
 		return new CallMethodsRule(
 			$broker,
-			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), true, true, true, true),
+			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion($this->phpVersion), true, true, true, true),
 			$ruleLevelHelper,
 			true,
 			true
@@ -1601,4 +1604,27 @@ public function testDisallowNamedArguments(): void
 		]);
 	}
 
+	public function testNamedArguments(): void
+	{
+		if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires PHP 8.0.');
+		}
+
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->phpVersion = 80000;
+
+		$this->analyse([__DIR__ . '/data/named-arguments.php'], [
+			[
+				'Named argument cannot be followed by a positional argument.',
+				21,
+			],
+			[
+				'Named argument cannot be followed by a positional argument.',
+				22,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/named-arguments.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace NamedArgumentsMethod;
+
+class Foo
+{
+
+	public function doFoo(
+		int $i,
+		int $j,
+		int $k
+	)
+	{
+
+	}
+
+	public function doBar(): void
+	{
+		$this->doFoo(
+			i: 1,
+			2,
+			3
+		);
+	}
+
+}