Skip to content

Commit 54c1da1

Browse files
committed
Implement BitwiseAndHandler
1 parent 79aedb0 commit 54c1da1

File tree

3 files changed

+73
-0
lines changed

3 files changed

+73
-0
lines changed
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
<?php declare(strict_types = 1);
2+
3+
namespace PHPStan\Analyser\Generator\ExprHandler;
4+
5+
use Generator;
6+
use PhpParser\Node\Expr;
7+
use PhpParser\Node\Stmt;
8+
use PHPStan\Analyser\ExpressionContext;
9+
use PHPStan\Analyser\Generator\ExprAnalysisRequest;
10+
use PHPStan\Analyser\Generator\ExprAnalysisResult;
11+
use PHPStan\Analyser\Generator\ExprHandler;
12+
use PHPStan\Analyser\Generator\GeneratorScope;
13+
use PHPStan\Analyser\SpecifiedTypes;
14+
use PHPStan\DependencyInjection\AutowiredService;
15+
use PHPStan\Reflection\InitializerExprTypeResolver;
16+
use function array_merge;
17+
18+
/**
19+
* @implements ExprHandler<Expr\BinaryOp\BitwiseAnd>
20+
*/
21+
#[AutowiredService]
22+
final class BitwiseAndHandler implements ExprHandler
23+
{
24+
25+
public function __construct(private InitializerExprTypeResolver $initializerExprTypeResolver)
26+
{
27+
}
28+
29+
public function supports(Expr $expr): bool
30+
{
31+
return $expr instanceof Expr\BinaryOp\BitwiseAnd;
32+
}
33+
34+
public function analyseExpr(Stmt $stmt, Expr $expr, GeneratorScope $scope, ExpressionContext $context, ?callable $alternativeNodeCallback): Generator
35+
{
36+
$leftResult = yield new ExprAnalysisRequest($stmt, $expr->left, $scope, $context, $alternativeNodeCallback);
37+
$rightResult = yield new ExprAnalysisRequest($stmt, $expr->right, $leftResult->scope, $context, $alternativeNodeCallback);
38+
39+
return new ExprAnalysisResult(
40+
$this->initializerExprTypeResolver->getBitwiseAndTypeFromTypes($leftResult->type, $rightResult->type),
41+
$this->initializerExprTypeResolver->getBitwiseAndTypeFromTypes($leftResult->nativeType, $rightResult->nativeType),
42+
$rightResult->scope,
43+
hasYield: $leftResult->hasYield || $rightResult->hasYield,
44+
isAlwaysTerminating: $leftResult->isAlwaysTerminating || $rightResult->isAlwaysTerminating,
45+
throwPoints: array_merge($leftResult->throwPoints, $rightResult->throwPoints),
46+
impurePoints: array_merge($leftResult->impurePoints, $rightResult->impurePoints),
47+
specifiedTruthyTypes: new SpecifiedTypes(),
48+
specifiedFalseyTypes: new SpecifiedTypes(),
49+
specifiedNullTypes: new SpecifiedTypes(),
50+
);
51+
}
52+
53+
}

src/Reflection/InitializerExprTypeResolver.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -954,6 +954,11 @@ public function getBitwiseAndType(Expr $left, Expr $right, callable $getTypeCall
954954
$leftType = $getTypeCallback($left);
955955
$rightType = $getTypeCallback($right);
956956

957+
return $this->getBitwiseAndTypeFromTypes($leftType, $rightType);
958+
}
959+
960+
public function getBitwiseAndTypeFromTypes(Type $leftType, Type $rightType): Type
961+
{
957962
if ($leftType instanceof NeverType || $rightType instanceof NeverType) {
958963
return $this->getNeverType($leftType, $rightType);
959964
}

tests/PHPStan/Analyser/Generator/data/gnsr.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,21 @@ public function doMinus($a, $b, int $c, int $d): void
6767
assertNativeType('int', $c - $d);
6868
}
6969

70+
/**
71+
* @param int $a
72+
* @param int $b
73+
* @return void
74+
*/
75+
public function doBitwiseAnd($a, $b, int $c, int $d): void
76+
{
77+
assertType('int', $a & $b);
78+
assertNativeType('(float|int)', $a & $b);
79+
assertType('1', 1 & 1);
80+
assertNativeType('1', 1 & 1);
81+
assertType('int', $c & $d);
82+
assertNativeType('int', $c & $d);
83+
}
84+
7085
/**
7186
* @param int $a
7287
* @param int $b

0 commit comments

Comments
 (0)