Handle condition with always true/false

Author: VincentLanglet

src/Analyser/TypeSpecifier.php

@@ -575,10 +575,33 @@ public function specifyTypesInCondition(
 			if (!$scope instanceof MutatingScope) {
 				throw new ShouldNotHappenException();
 			}
-			$leftTypes = $this->specifyTypesInCondition($scope, $expr->left, $context, $rootExpr);
+
+			if ($expr instanceof BooleanAnd && $scope->getType($expr->left)->isTrue()->yes()) {
+				$leftTypes = null;
+			} else {
+				$leftTypes = $this->specifyTypesInCondition($scope, $expr->left, $context, $rootExpr);
+			}
+
 			$rightScope = $scope->filterByTruthyValue($expr->left);
-			$rightTypes = $this->specifyTypesInCondition($rightScope, $expr->right, $context, $rootExpr);
-			$types = $context->true() ? $leftTypes->unionWith($rightTypes) : $leftTypes->normalize($scope)->intersectWith($rightTypes->normalize($rightScope));
+			if ($expr instanceof BooleanAnd && $rightScope->getType($expr->right)->isTrue()->yes()) {
+				$rightTypes = null;
+			} else {
+				$rightTypes = $this->specifyTypesInCondition($rightScope, $expr->right, $context, $rootExpr);
+			}
+
+			if (null === $leftTypes && null === $rightTypes) {
+				return new SpecifiedTypes([], [], false, [], $expr);
+			}
+			if (null === $leftTypes) {
+				return $context->true() ? $rightTypes : $rightTypes->normalize($rightScope);
+			}
+			if (null === $rightTypes) {
+				return $context->true() ? $leftTypes : $leftTypes->normalize($scope);
+			}
+
+			$types = $context->true()
+				? $leftTypes->unionWith($rightTypes)
+				: $leftTypes->normalize($scope)->intersectWith($rightTypes->normalize($rightScope));
 			if ($context->false()) {
 				return new SpecifiedTypes(
 					$types->getSureTypes(),
@@ -599,10 +622,33 @@ public function specifyTypesInCondition(
 			if (!$scope instanceof MutatingScope) {
 				throw new ShouldNotHappenException();
 			}
-			$leftTypes = $this->specifyTypesInCondition($scope, $expr->left, $context, $rootExpr);
+
+			if ($expr instanceof BooleanOr && $scope->getType($expr->left)->isFalse()->yes()) {
+				$leftTypes = null;
+			} else {
+				$leftTypes = $this->specifyTypesInCondition($scope, $expr->left, $context, $rootExpr);
+			}
+
 			$rightScope = $scope->filterByFalseyValue($expr->left);
-			$rightTypes = $this->specifyTypesInCondition($rightScope, $expr->right, $context, $rootExpr);
-			$types = $context->true() ? $leftTypes->normalize($scope)->intersectWith($rightTypes->normalize($rightScope)) : $leftTypes->unionWith($rightTypes);
+			if ($expr instanceof BooleanOr && $rightScope->getType($expr->right)->isFalse()->yes()) {
+				$rightTypes = null;
+			} else {
+				$rightTypes = $this->specifyTypesInCondition($rightScope, $expr->right, $context, $rootExpr);
+			}
+
+			if (null === $leftTypes && null === $rightTypes) {
+				return new SpecifiedTypes([], [], false, [], $expr);
+			}
+			if (null === $leftTypes) {
+				return $context->true() ? $rightTypes->normalize($rightScope) : $rightTypes;
+			}
+			if (null === $rightTypes) {
+				return $context->true() ? $leftTypes->normalize($scope) : $leftTypes;
+			}
+
+			$types = $context->true()
+				? $leftTypes->normalize($scope)->intersectWith($rightTypes->normalize($rightScope))
+				: $leftTypes->unionWith($rightTypes);
 			if ($context->true()) {
 				return new SpecifiedTypes(
 					$types->getSureTypes(),

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -864,4 +864,10 @@ public function testBug10997(): void
 		]);
 	}
 
+	public function testBug11276(): void
+	{
+		$this->reportPossiblyNonexistentConstantArrayOffset = true;
+		$this->analyse([__DIR__ . '/data/bug-11276.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Arrays/data/bug-11276.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11276;
+
+class HelloWorld
+{
+	/**
+	 * @param array{from: string, to: string} $expected
+	 */
+	public function testLanguagesMatchingRegex(string $url, ?array $expected): void
+	{
+		preg_match('#\/(?<from>[a-z]{2})-(?<to>[a-z]{1}[a-z0-9]{1})\/#', $url, $matches);
+
+		foreach ($expected as $key => $value) {
+			if ($matches instanceof ArrayAccess || \array_key_exists($key, $matches)) {
+				$matches[$key];
+			}
+		}
+
+		foreach ($expected as $key => $value) {
+			if (\array_key_exists($key, $matches) || $matches instanceof ArrayAccess) {
+				$matches[$key];
+			}
+		}
+
+		foreach ($expected as $key => $value) {
+			if (!$matches instanceof ArrayAccess && !\array_key_exists($key, $matches)) {
+			} else {
+				$matches[$key];
+			}
+		}
+
+		foreach ($expected as $key => $value) {
+			if (!\array_key_exists($key, $matches) && !$matches instanceof ArrayAccess) {
+			} else {
+				$matches[$key];
+			}
+		}
+	}
+}