-
Notifications
You must be signed in to change notification settings - Fork 545
Support value-of<BackedEnum>
#1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
da906a9
added failling value-of<BackedEnum> test
clxmstaab 698eb7a
support value-of<BackedEnum>
clxmstaab 60398d4
cs
clxmstaab 2c1464f
add null check
clxmstaab 13f4350
fix
clxmstaab 3ce6840
work on PR feedback
clxmstaab b6bce3d
cs
clxmstaab f04b4cd
remove unrelated line
clxmstaab d1e9f14
added testcoverage in CallMethodsRuleTest
clxmstaab 54c2e3b
adjust test to better match the test-file-name
clxmstaab b4eeba0
added NodeScopeResolverTest
clxmstaab d9bed9f
fix
clxmstaab e85f61b
remove require
clxmstaab 94fed32
Revert "remove require"
clxmstaab 269e50e
fix tests
clxmstaab 277f7e6
fix tests
clxmstaab 2759d26
fix tests
clxmstaab 7b62697
remove require
staabm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?php // lint >= 8.1 | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ValueOfEnum; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| enum Country: string | ||
| { | ||
| case NL = 'The Netherlands'; | ||
| case US = 'United States'; | ||
| } | ||
|
|
||
| class Foo { | ||
| /** | ||
| * @return value-of<Country> | ||
| */ | ||
| function us() | ||
| { | ||
| return Country::US; | ||
| } | ||
|
|
||
| /** | ||
| * @param value-of<Country> $countryName | ||
| */ | ||
| function hello($countryName) | ||
| { | ||
| assertType("'The Netherlands'|'United States'", $countryName); | ||
| } | ||
|
|
||
| function doFoo() { | ||
| assertType("'The Netherlands'|'United States'", $this->us()); | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <?php // lint >= 8.1 | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ValueOfEnum; | ||
|
|
||
| enum Country: string | ||
| { | ||
| case NL = 'The Netherlands'; | ||
| case US = 'United States'; | ||
| } | ||
|
|
||
| enum CountryNo: int | ||
| { | ||
| case NL = 1; | ||
| case US = 2; | ||
| } | ||
|
|
||
| class Foo { | ||
| /** | ||
| * @param value-of<Country> $countryName | ||
| */ | ||
| function hello(string $countryName): void | ||
staabm marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
| // ... | ||
| } | ||
|
|
||
| /** | ||
| * @param value-of<Country> $shouldError | ||
| */ | ||
| function helloError(int $shouldError): void | ||
| { | ||
| // ... | ||
| } | ||
| /** | ||
| * @param value-of<CountryNo> $shouldError | ||
| */ | ||
| function helloError2(string $shouldError): void | ||
| { | ||
| // ... | ||
| } | ||
|
|
||
| function doFoo() { | ||
| $this->hello(Country::NL); | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as expected, we now see errors here.