Skip to content

Conversation

@swiffer
Copy link

@swiffer swiffer commented Oct 18, 2020

No description provided.

@swiffer
Copy link
Author

swiffer commented Oct 18, 2020

Does it fix phpstan/phpstan#3918

@ondrejmirtes
Copy link
Member

Recursive mkdir isn't thread-safe so this solution cannot be used.

@ondrejmirtes
Copy link
Member

And it misses what's actually going on, which I described in this comment: phpstan/phpstan#3918 (comment)

@swiffer
Copy link
Author

swiffer commented Oct 18, 2020

@ondrejmirtes yeah, seems to miss what's going on according to your comment, seems to be a different issue - but

when i'm using any version newer than 0.12.42 for me running phpstan in ci fails because of:

Cannot create a temp directory /builds/my_project/.cache/phpstan

(where .cache and .cache/phpstan where not existing)

with

includes:
	- vendor/phpstan/phpstan/conf/bleedingEdge.neon
parameters:
    level: 7
    phpVersion: 70400
    checkMissingIterableValueType: false
    bootstrapFiles:
        - config/bootstrap.php
    tmpDir: .cache/phpstan
    paths:
        - src
    excludes_analyse:
        - src/Console/Installer.php

i've now added mkdir -p .cache to ensure the .cache dir exist prior to running phpstan and this indeed fixes the problem for me.

@ondrejmirtes
Copy link
Member

This changes things as they were pre-0.12.42: 5be8b80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants