More precise types in immediately invoked callables #3592
Conversation
|
Thanks so much @staabm. I just tested this on TwigStan and it solves the problem. 🎉 This was a major blocker, as proper analysis of templates after such immediately involved callable became impossible. It would be really great if this can make it in a last 1.12 release 🙏 |
| $this->inFuncCall | ||
| && $node instanceof Node\Expr\Closure | ||
| ) { | ||
| $node->setAttribute(self::ATTRIBUTE_NAME, true); |
There was a problem hiding this comment.
This would lead to a lot of false positives. You only want to tag this if in $node->name, but right now the visitor is tagging args too.
Just check $node->name inside $node instanceof Node\Expr\FuncCall.
|
retargeted for 1.12 in #3593 |
| assertType('array{date: DateTime, id: 1}', $c); | ||
|
|
||
| $x = (function() use (&$c) { | ||
| assertType("array{date: DateTime, id: 1, name?: 'ruud'}", $c); |
There was a problem hiding this comment.
I believe this is wrong, see phpstan/phpstan#11945
There was a problem hiding this comment.
My reasoning is, that since this function is invoked immediately, it should be treated as the same code as normally, without the function.
| return 'x'; | ||
| })(); | ||
|
|
||
| assertType("array{date: DateTime, id: 1, name?: 'ruud'}", $c); |
There was a problem hiding this comment.
I believe this is wrong, see phpstan/phpstan#11945
3 participants
closes phpstan/phpstan#11561